<?xml version="1.0"?>
<ArrayOfFBEvent xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-05-24T20:56:14Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Jaime Lopez</User>
    <Comment>Verified with DataPRO 4.0.906, 4.1.252
 
In system settings enable "allow calculated channels"
 
 
Add calculated channels with the operator as HIC</Comment>
    <StatusString>Closed</StatusString>
    <TimeStamp>2023-04-03T20:34:32Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Closed</Status>
  </FBEvent>
  <FBEvent>
    <User>Jaime Lopez</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2023-03-31T20:45:24Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>4.0/4.1@48444</Comment>
    <StatusString>Resolved</StatusString>
    <TimeStamp>2023-03-28T14:25:38Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Resolved</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>Jerry, John,
 
I've attached a patch for 4.0 MAINT for:
 
30416
 test setup unable to save, when there's a HIC calculated channel
 
 
 
I found some issues here.  The first issue is that the HIC channels were being discarded by TestTemplate.UpdateCalculatedChannels.  This function may have been added for 28099 Exporting test setup does not export calculated channels.  This issue should also be retested after the patch is applied.  This function was making use of CalculatedChannel.InputChannels, however this was empty in the case of a HIC.  In the case of a HIC CalculatedChannel.ISOCalculatedChannel.InputChannels was being updated instead and not the wrapping class.  It's lost to me why there is an inner and and outer class, my guess is we had the outer class for GUI purposes and the inner class for storage purposes but duplicated the storage properties in the GUI CalculatedChannel class.
 
The solution has a couple changes in SetHICChannelsToCC() it sets both the outer and inner class properties, it also now checks for null before accessing an input channel (in multiple locations)
 
the issue above has a 4.0 database that can be used.  It's not necessary to try the import, you can actually use the existing test (or just create your own new test with an X,Y, Z accel channel and HIC calculated channel).  The first test (TGVA FRONT FLAT 56KMH 20221031) has a HIC already defined.  Prepatch if you assign an X,Y,Z channel and save it will not save the channels, after saving the test the channels will be unassigned and in the database you'll see:
 
 
After the patch the channels should get saved to the DB and should show up assigned to the calculated channel after saving the test setup.
 
 
You should be able to add all 3 channels and save the calculated channel, you should be able to add a new HIC with only Y set, and hit save - however it will return an error and not save the test setup.  The patch also addresses some crashes when you try this that probably also available if you switched between partially defined HICs after the patch (since CalculatedChannel.InputChannels is now defined it accesses [0].SerialNumber and similar properties in some places).
 
 
The database should be considered confidential.</Comment>
    <StatusString>Assigned</StatusString>
    <TimeStamp>2023-03-27T21:36:38Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-03-27T20:54:56Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>I notice this in the Save Failure.log;
 
 
 
An exception of type: System.FormatException occurred Module: mscorlib.dll, Name: StringToNumberMessage: Input string was not in a correct format. StackTrace:    at System.Number.StringToNumber(String str, NumberStyles options, NumberBuffer&amp; number, NumberFormatInfo info, Boolean parseDecimal) StackTrace:    at System.Number.ParseInt64(String value, NumberStyles options, NumberFormatInfo numfmt)    at DataPROWin7.DataModel.TestTemplate.ValidateCalculatedChannels(List`1&amp; errors, List`1&amp; warnings, TestTemplate currentTest)    at DataPROWin7.Controls.EditTestSetupCalculatedChannels.Validate(
 
this suggests there's something other than a number in a calculated channel where a number was expected.</Comment>
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-03-27T17:50:18Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2023-03-16T17:54:02Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-03-16T17:53:50Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2023-03-16T17:53:25Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>Adam has found these issues in DataPRO 4.0:
  
 
 
Test Setup unable to save. He can export and re-import but the test setup is corrupted and unsaveable in DataPRO. A unique note, this test has a HIC calculation, which seems like the culprit
 
 
 
The “Bad test setup” was first. I was building a TS and walked away from my computer and it locked. When I came back I couldn’t save the TS. Got the “failed to update lock”. Then the shutdown error. After I restarted DP I couldn’t open the TS. Every time I would get the shutdown error. Exported the TS and then deleted it.
 
 
 
Then I imported the CSV again(Save failure), added hardware, saved, assigned hardware, saved, added squib channels and calculations (HIC), saved and got the shutdown error again.
 
 
 
Now it won’t open the TS again. Just keep getting the shutdown error.
 
 
 
Everything is Local on my computer.
 
 
Hey Nate,
 
If we are going to start a ticket for this, I will give some other thing I found.
 
When importing a test setup, and you have the browse window open and select ‘All Files’, you get the ‘Data at the root level…’ error. When you choose the correct file type, it works fine.
 
 When adding calculations. That crashes it. And the test setup can’t be opened again.</Comment>
    <StatusString>Opened</StatusString>
    <TimeStamp>2023-03-16T17:53:24Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Opened</Status>
  </FBEvent>
</ArrayOfFBEvent>