<?xml version="1.0"?>
<ArrayOfFBEvent xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2025-03-20T21:56:47Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Jaime Lopez</User>
    <Comment>verified</Comment>
    <StatusString>Closed</StatusString>
    <TimeStamp>2025-02-21T17:54:56Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Closed</Status>
  </FBEvent>
  <FBEvent>
    <User>Jaime Lopez</User>
    <Comment>Testing with DataPRO v4.2.533</Comment>
    <StatusString>Edited</StatusString>
    <TimeStamp>2025-02-20T22:57:04Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Jaime Lopez</User>
    <Comment>Testing with DataPRO v4.3.551</Comment>
    <StatusString>Edited</StatusString>
    <TimeStamp>2025-02-20T22:41:48Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Jaime Lopez</User>
    <Comment>Testing with DataPRO v4.4.157</Comment>
    <StatusString>Edited</StatusString>
    <TimeStamp>2025-02-20T22:32:55Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Jaime Lopez</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2025-01-16T22:56:02Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>ReleaseNoted</StatusString>
    <TimeStamp>2025-01-07T22:38:33Z</TimeStamp>
    <ReleaseNote>Adjusts SLICE Pro Distributor input voltage min to 36.5 and max to 56</ReleaseNote>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>4.0/4.2/4.3/4.4@51805</Comment>
    <StatusString>Resolved</StatusString>
    <TimeStamp>2025-01-07T18:58:10Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Resolved</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2025-01-07T18:47:35Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>I’ve changed the patch and abstracted out the constants into a new file (DASSpecific\SliceProDb)
 
 
 
The functionality is the same, however this will make it easier in the future if we need to change the values.
 
 
 
The reason I don’t just flat out replace the settings in the database with hard coded ones is to allow the user to have some flexibility to change the values, for example the 22V input setting that was in prepatch was way lower than what the device is capable of, but if the user purposely sets it to 35 instead of 36.5 I think that’s within reason and we should allow that.
 
 
 
It doesn’t change the behavior of any of the power settings, so you can still set other power settings to invalid values like -10, etc, it also doesn’t change the decoration of invalid values and so on, would be nice to correct those but that would take a little time and is beyond the scope requested by summer in the original ticket, she just wanted to make sure the defaults of 36.5 and 56V would be used and the user setting of 22V which was in prepatch would not be used.</Comment>
    <StatusString>Edited</StatusString>
    <TimeStamp>2025-01-07T17:51:41Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2025-01-03T19:20:30Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>Jerry,
 
 
 
I’ve submitted a patch into 4.0 DEVEL for
 
 
 
43288
 
SPDB Input Voltage
 
 
 
In this ticket Summer requested changes to the SPDB input voltage low and high values.
 
 
 
The values are retrieved here:
 
 
 
 
 
        public static DasBatteryInputSettings SLICEPRODistributor_PowerSetting
 
 
 
if the settings aren’t in the database, then a default setting from code is used.
 
 
 
I corrected the default in code and also added code in the retrieval to adjust the high and low if they are grossly far away from targets, like the low was in summer’s example.  This still allows the user a couple of volts leeway in setting the low and high values.
 
 
 
Here are the thresholds:
 
 
 
                if (setting.MinimumValidInputThreshold &lt; 30 || setting.MinimumValidInputThreshold &gt;40) { setting.MinimumValidInputThreshold = 35; }
 
                if (setting.MaximumValidInputThreshold &gt; 60 || setting.MaximumValidInputThreshold &lt; 50) { setting.MaximumValidInputThreshold = 57; }
 
                //if low is grossly wrong, correct it, we expect 36.5
 
                if ( setting.InputLowArmedThreshold &gt; 40 || setting.InputLowArmedThreshold &lt; 30)
 
                {
 
                    setting.InputLowArmedThreshold = 36.5;
 
                    setting.InputLowDiagnosticsThreshold = 36.5;
 
                    setting.InputMediumArmedThreshold = 46;
 
                    setting.InputMediumDiagnosticsThreshold = 46;
 
                }
 
                //if high setting is grossly less than the high we expect, correct it
 
                if (setting.InputHighArmedThreshold &lt; 50 || setting.InputHighArmedThreshold &gt; 60)
 
                {
 
                    setting.InputHighArmedThreshold = 56;
 
                    setting.InputHighDiagnosticsThreshold = 56;
 
                    setting.InputMediumArmedThreshold = 46;
 
                    setting.InputMediumDiagnosticsThreshold = 46;
 
                }
 
 
 
That’s also pretty much all of the patch.
 
 
 
Now if you’ve run datapro already with old code it may have written the default values into the database when it found them missing, so migrating from 4.0.x to 4.0.y the .x database could have the old values in it.  The code that corrects when reading should take over at that point and put them at the values we expect.
 
 
 
The patch is for 4.0, a slightly different patch is needed for 4.2 and beyond but it doesn’t change functionality at all, just some formatting.
 
 
 
I did not run with hardware, SQA should definitely run with hardware, I only checked that it was showing properly in the system settings-&gt;power settings area.</Comment>
    <StatusString>Assigned</StatusString>
    <TimeStamp>2025-01-03T19:18:57Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>40 patch attached</Comment>
    <StatusString>Edited</StatusString>
    <TimeStamp>2025-01-03T18:52:55Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2025-01-03T18:50:30Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>the setting if not present in the database is updated (the defaults) in addition when retrieving the settings it should coerce the values the 36.5 and 56 if they are grossly out of range.  Here's the criteria I'm using for that:
 
                if (setting.MinimumValidInputThreshold &lt; 30 || setting.MinimumValidInputThreshold &gt;40) { setting.MinimumValidInputThreshold = 35; }
                 if (setting.MaximumValidInputThreshold &gt; 60 || setting.MaximumValidInputThreshold &lt; 50) { setting.MaximumValidInputThreshold = 57; }
 
                if ( setting.InputLowArmedThreshold &gt; 40 || setting.InputLowArmedThreshold &lt; 30)
                 {
                     setting.InputLowArmedThreshold = 36.5;
                     setting.InputLowDiagnosticsThreshold = 36.5;
                     setting.InputMediumArmedThreshold = 46;
                     setting.InputMediumDiagnosticsThreshold = 46;
                 }
 
 
 
                if (setting.InputHighArmedThreshold &lt; 50 || setting.InputHighArmedThreshold &gt; 60)
                 {
                     setting.InputHighArmedThreshold = 56;
                     setting.InputHighDiagnosticsThreshold = 56;
                     setting.InputMediumArmedThreshold = 46;
                     setting.InputMediumDiagnosticsThreshold = 46;
                 }</Comment>
    <StatusString>Edited</StatusString>
    <TimeStamp>2025-01-03T18:50:09Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>the values set here are
 
                    var requirements = new[] {InputLowVoltage, InputHighVoltage, BatteryLowVoltage, BatteryHighVoltage};
                     ssaV.SetValue(AttributeTypes.SystemAttributesSLICE6DB.VoltageRequirements, requirements, true);</Comment>
    <StatusString>Edited</StatusString>
    <TimeStamp>2025-01-03T18:15:38Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2025-01-03T17:08:33Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-12-18T16:55:13Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>needs to update settings in database as far back as DP 4.0</Comment>
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-12-17T00:11:48Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Summer Tirado</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-12-17T00:08:00Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Summer Tirado</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2024-12-17T00:07:39Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Summer Tirado</User>
    <Comment>Hello, 

Please see the attached screenshot from DataPro showing incorrect input voltage values. Please update DataPro to show minimum input voltage set to 36.5V and maximum input voltage set to 56V. Wiki link below.


http://dtsinfo/dtswiki/index.php/SLICE_PRO_DISTRIBUTOR_Production_Attribute_Settings</Comment>
    <StatusString>Opened</StatusString>
    <TimeStamp>2024-12-17T00:07:39Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Opened</Status>
  </FBEvent>
</ArrayOfFBEvent>