<?xml version="1.0"?>
<ArrayOfFBEvent xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-08-24T00:14:32Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Justin Richardson</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-06-04T20:06:25Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Justin Richardson</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-06-04T20:06:12Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Justin Richardson</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-06-04T20:05:50Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>ReleaseNoted</StatusString>
    <TimeStamp>2024-06-04T17:56:37Z</TimeStamp>
    <ReleaseNote>TOM diagnostics now always take place before squib fire check and a delay of 0 is no longer allowed</ReleaseNote>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-06-04T17:10:45Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Closed</StatusString>
    <TimeStamp>2024-06-04T15:39:55Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Closed</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Resolved</StatusString>
    <TimeStamp>2024-06-04T15:39:51Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Resolved</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Reopened</StatusString>
    <TimeStamp>2024-06-04T15:39:47Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Justin Richardson</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-06-03T22:25:18Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Justin Richardson</User>
    <Comment>Verified  tom warmup times are observed and  times set in  system settings&gt; test setup 

In datapro versions
4.3.181.50853
 4.2.425.50851
4.0.1160.50851

- Testing by setting warmup times to different values and observing different wait times in diagnostics and checking logs to verify ..


-Tested When setting Warmup time to 0 and datapro log indicates  10 seconds ( default )  warmup time as expected..
</Comment>
    <StatusString>Closed</StatusString>
    <TimeStamp>2024-06-03T20:52:15Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Closed</Status>
  </FBEvent>
  <FBEvent>
    <User>Justin Richardson</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2024-06-03T17:24:58Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>4.0/4.2/4.3@50841</Comment>
    <StatusString>Resolved</StatusString>
    <TimeStamp>2024-05-29T17:17:11Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Resolved</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2024-05-28T21:08:33Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>to assist in validating this I added logging for the start of the excitation warmup and the completion of excitation warmup.  
 
2024-05-28 13:53:29.845 Starting TOM warmup
 ... 
 2024-05-28 13:53:49.853 Completed TOM warmup</Comment>
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-05-28T20:57:40Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>during testing it seems like DataPRO 4.0 does always wait for DefaultTestExcitationTOMWarmupDelayMS
 
It does this in the general excitation warmup time that happens when you hit run diagnostics.  This is a user specific setting, it's always possible the setting did not exist for a user.  Regardless of the excitation time waited here there was an additional 10s wait during the squib fire check in diagnotics for SPT.  It would always do this wait before running the squib fire check.  
 
 
 
I will move the wait that happens during the regular excitation warmup time into where the existing 10s hard coded warmup is and will additionally have it check and use 20seconds if no wait time is set in the setting.</Comment>
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-05-28T20:51:34Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>I could not duplicate the original issue, it _IS_ waiting for the TOM warmup time, however it only does it for the initial warmup, it probably should do it before EVERY squib fire check, so I'll move it, here's the original code:
 
            if (CurrentTest.CheckForTOM())
             {
                 //Wait at least (the default is 20 seconds) for squibs to warm up
                 maxWarmup = Math.Max(maxWarmup, setting.DefaultTestExcitationTOMWarmupDelayMS);
             }</Comment>
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-05-28T20:27:19Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-05-28T20:18:59Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-05-28T20:17:19Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>there's code internally that suggests it's always a hardcoded 10s for diagnostics for SPTs;
 
            // TDAS TOM's do not need this because cap charging is already verified in AsyncDiagnosAndGetResults()
             if (!hasOnlyTdasTom)     // 10s to fully charge slicepro capacitors...
 
here's where the setting is in the UI;
 
 
 
 
the code looks like it expects to execute this warmup just once, at the initial warmup;
 
            if (CurrentTest.CheckForTOM())
             {
                 //Wait at least (the default is 20 seconds) for squibs to warm up
                 maxWarmup = Math.Max(maxWarmup, setting.DefaultTestExcitationTOMWarmupDelayMS);
             }</Comment>
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-05-28T20:15:33Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-05-23T00:02:49Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2024-05-21T23:38:06Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-05-21T20:32:19Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2024-05-20T15:11:55Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Opened</StatusString>
    <TimeStamp>2024-05-20T15:11:54Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Opened</Status>
  </FBEvent>
</ArrayOfFBEvent>