<?xml version="1.0"?>
<ArrayOfFBEvent xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <FBEvent>
    <User>Justin Richardson</User>
    <Comment>Verified with dp 4.2.322   and 4.0.1117

Tested with 2 SPS with multiple roi regions assigned , removed one SPS After triggering before proceeding to download tab .
Datapro gave pop up message that not all channels expected  were downloaded but was able to download the remaining channels and roi  from the sps that was still connected.

The only Roi that didnt download  was roi 4 which was only assigned to a channel  on the das that was removed  .

</Comment>
    <StatusString>Closed</StatusString>
    <TimeStamp>2024-01-09T22:52:29Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Closed</Status>
  </FBEvent>
  <FBEvent>
    <User>Khanh Nguyen</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-01-09T17:27:03Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Justin Richardson</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2024-01-08T16:51:08Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2024-01-02T16:22:17Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>ReleaseNoted</StatusString>
    <TimeStamp>2023-12-05T19:26:57Z</TimeStamp>
    <ReleaseNote>Now allows viewing ROI as long as at least one ROI downloads prior to a download failure</ReleaseNote>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>ReleaseNoted</StatusString>
    <TimeStamp>2023-12-05T19:26:49Z</TimeStamp>
    <ReleaseNote>now allows viewing ROI as long as at least one ROI downloads prior to a download failure</ReleaseNote>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-12-05T18:34:35Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-12-04T21:38:47Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-11-29T22:45:41Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>4.0/4.2@49916</Comment>
    <StatusString>Resolved</StatusString>
    <TimeStamp>2023-11-29T22:45:36Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Resolved</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>This is a complicated issue, so this patch may just be addressing one aspect of the problem.
 
There's code in the OverallStatus property that was acting on the overallstatus to control whether view is available or not, but in the case of a multiple ROI download and specifically if there's a partial download like in this case the overall status could be "failed" in which case it won't enable the view step.
 
The patch will enable the view step as long as any of the partial downloads succeeds.  it only enables this if there's a partial download situation (so at least one das missing).
 
I also noticed that the overall status could get confused and off timed as it's async and so sometimes "Starting region download" would be displayed even though that step was happening much earlier.
 
To deal with this the SetAggregateStatus and SetAggregateColor methods now wait before returning, this could potentially create a deadlock though.
 
there are multiple test cases to consider, the one I specifically looked at was
 
3 roi periods, roi contains channels from both DAS, roi 2 contains only first das, roi 3 contains only channels from 2nd das.  Hit stop monitoring and then trigger and remove second das prior to downloading.
 
Other cases such as first roi contains no downloadable channels should be tested, basically swapping roi 3 and 1's channel assignements.
 
It also needs to work properly in download all.
 
it will stop the downloading process with the first ROI that fails, so if there are no channels to download in the first ROI then no ROI will be downloaded, but it should be possible to unselect that ROI and still download from the remaining ROI</Comment>
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-11-28T22:41:55Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2023-11-28T18:24:15Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>this gets complicated;
 
in this case we have a partial download (since some das are missing) but also at least one download succeeds and one fails
 
right now with the ROI that fails completely is setting the overall status to failed, which is preventing continuing to view.
 
In this case we want to go to "Partially finished" since some finished and some didn't ...</Comment>
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-11-28T17:20:44Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2023-11-28T16:59:01Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-11-22T22:04:44Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2023-11-21T23:05:46Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-11-21T23:05:25Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2023-11-21T23:03:38Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-11-21T19:17:07Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Jerry Lawrence</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2023-11-21T17:10:07Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2023-11-16T19:30:28Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Justin Richardson</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-11-16T18:39:47Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Justin Richardson</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-11-16T18:38:45Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Justin Richardson</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-11-16T18:37:47Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Justin Richardson</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2023-11-16T18:35:33Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Justin Richardson</User>
    <Comment>![](index.php?/attachments/get/43059)

![](index.php?/attachments/get/43061)

After clicking ok On modal Popup  Starting region Download banner appears and User cannot click to view Roi ..
![](index.php?/attachments/get/43062)

If I click  on run Download Roi again  The same steps above are repeated .

T458108: Download using download data tile with multiple ROI with missing DAS
http://testrailserver/index.php?/tests/view/458108


To Reproduce:

1. I used 2 SPS connected together  on one ECM and created a test setup with a few channels from each sps , added 3 roi regions and assigned them   to channels from each das  ..

2. Armed in circ buffer for 10 sec post triggered and then clicked Done to return , then remove the second SPS from the chain ... 
3. Proceed to Download Tab and proceed through to Downalod Roi ..
When running download roi  click to  proceed on the  modal popup   "The following hardware is not connected"   and downloading begins...then  shortly after  another  modal pops up "Warning Not all channels expected were downloaded"   Click ok  on that one 
 And a yellow banner is shown "Starting Region download"   View ROI step is  disabled "Grayed out " and  the only option is to Run Download ROi again with same results... or click done and exit .
So it looks as if you are stuck in a loop   and cant proceed to View Roi step.

![](index.php?/attachments/get/43063)


</Comment>
    <StatusString>Opened</StatusString>
    <TimeStamp>2023-11-16T18:35:33Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Opened</Status>
  </FBEvent>
</ArrayOfFBEvent>