<?xml version="1.0"?>
<ArrayOfFBEvent xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-05-24T20:57:22Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>ReleaseNoted</StatusString>
    <TimeStamp>2023-04-11T20:25:29Z</TimeStamp>
    <ReleaseNote>Corrects issue where TSR AIR could run trigger check multiple times</ReleaseNote>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Closed</StatusString>
    <TimeStamp>2023-04-11T14:42:57Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Closed</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Resolved</StatusString>
    <TimeStamp>2023-04-11T14:42:54Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Resolved</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Reopened</StatusString>
    <TimeStamp>2023-04-11T14:42:48Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Jaime Lopez</User>
    <Comment>Reproduced bug for max events on TSR AIR
 
Test 1:
 
Setting to 0, Max events gets set to 1
 
Test 2:
 
Reproduced bug: 4.0.906
 
Verified fix in 4.0.910, 4.1.257
 
With Check Trigger Quick Mode disable and setting to 5 events in active mode
 
In Check Trigger I only had to trigger once, I also noticed that before patch DP would only want 1 trigger and Change number of events from 5 to 1. Here it shows that we are expecting 5 events.</Comment>
    <StatusString>Closed</StatusString>
    <TimeStamp>2023-04-10T21:01:28Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Closed</Status>
  </FBEvent>
  <FBEvent>
    <User>Jaime Lopez</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2023-04-05T23:34:52Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>4.0/4.1@48473</Comment>
    <StatusString>Resolved</StatusString>
    <TimeStamp>2023-04-05T23:29:28Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Resolved</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-04-05T17:37:19Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>The patch has two fixes.  One fix is I added a new SetMaxEvents method which sets the max number of events.  For all non TSR AIR this means setting the MaxEvents attribute, but for TSR AIR this means setting the MaxEventsPossible attribute.  This attribute has two values, the first value is the number of events determined by the firmware, and the second is the number requested by software.  When the number requested by software is 0 the max number possible will be calculated and the max requested will be set to the max available.  I noticed in GetMaxTSRAIREvents that it wasn't forcing the calculation before getting the max number of events possible, this could cause it to incorrectly assume the number of events possible.  In fact there is an issue that says exactly this happens, but I didn't have a route to duplicate it.  This might suggest there's a route.
 
to duplicate this issue run a TSR AIR with check trigger with quick trigger check turned off in system settings with a number of events &gt; 3.  Prior to the patch it will arm the unit and stay in "Post Test Processing" until you hit trigger enough time to cover all the multiple events.
 
note that the number of events could be from previous runs, so you might have to run a test with multiple events first to duplicate.  Under the cover it was setting "MaxEvents" to 1, but this attribute is ignored in the TSR AIR, it needs to set a different attribute.
 
 
 
 
 
 
 
 
 
 
 Attachments: 
    DTM_30431_CheckTrigger.patch 9.8 KB</Comment>
    <StatusString>Assigned</StatusString>
    <TimeStamp>2023-04-05T17:36:22Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-04-05T16:25:37Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>speaking with EFizer the MaxEvents attribute is not used for TSRAIR, the MAXEventsPossible attribute has to be set instead.  This attribute has two values, the second of which is the # of requested events?
 
will check wiki for more info
 
 
from the wiki:
      171 MaxEventsPossible (x, y) (max events possible, requested number of events) requested number (y) will be set to max if it is too large to fit into memory. Setting y=0 will calculate and set the max value for x and y.</Comment>
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-04-05T16:21:56Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment>unit is armed for 1 event and still re-arms, will need to check with FW to see what to do, can be replicated in FWTU.</Comment>
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-04-05T16:09:08Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2023-04-05T14:29:58Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-03-28T21:45:18Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-03-27T15:47:52Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Chris Balogh</User>
    <Comment />
    <StatusString>Edited</StatusString>
    <TimeStamp>2023-03-23T18:29:16Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Assigned</StatusString>
    <TimeStamp>2023-03-21T20:08:27Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>UNKNOWN</Status>
  </FBEvent>
  <FBEvent>
    <User>Dan McFadden</User>
    <Comment />
    <StatusString>Opened</StatusString>
    <TimeStamp>2023-03-21T20:08:27Z</TimeStamp>
    <ZendeskNumber>0</ZendeskNumber>
    <Status>Opened</Status>
  </FBEvent>
</ArrayOfFBEvent>