View

1. Purpose

This module implements the WPF view layer (ChannelCodesListView) for a channel codes management UI, adhering to the IChannelCodesListView interface. It provides interactive controls for viewing, editing, sorting, filtering, and selecting channel codes in two distinct modes: ISO and User. The view binds to an IChannelCodesListViewModel and handles user interactions such as text edits, checkbox toggles, column header clicks, and selection changes, delegating state management and validation logic to the view model.

2. Public Interface

The class ChannelCodesListView implements IChannelCodesListView (via partial class + : IChannelCodesListView) and exposes only its constructor publicly. All other members are private event handlers wired via XAML. No public methods or properties are defined in this file.

Constructor

ChannelCodesListView()
Initializes the WPF component by calling InitializeComponent(). Sets up the visual tree defined in ChannelCodesListView.xaml.

All other functionality is exposed indirectly via event handlers attached to XAML elements (e.g., KeyDown, TextChanged, SelectionChanged, Click), which internally interact with the DataContext (expected to be an IChannelCodesListViewModel).

3. Invariants

The DataContext must be an instance implementing IChannelCodesListViewModel; otherwise, most event handlers silently return.
Column sorting and filtering rely on the Tag property of GridViewColumnHeaderSearchable elements (e.g., ISOCodeColumnHeader, UserCodeColumnHeader). These tags must be non-null and correspond to valid filter/sort keys expected by the view model.
Selection changes in either ISOChannelCodesListView or UserChannelCodesListView must result in exactly one IChannelCode item being selected per list (based on handler logic in ISO_Checked/User_Checked and selection handlers), though the code does not enforce uniqueness beyond what the view model allows.
The ChannelCodeBuilder_OnChannelCodeSelected handler assumes that if channelCode.Name is null/whitespace, it should be overwritten with the selected name parameter.
Text/keydown handlers for ChannelCodeTextBoxUser, DisplayNameTextBoxUser, ChannelCodeTextBoxIso, and DisplayNameTextBoxIso always call MarkModified(channelCode) and then invoke ValidateUser(...) or ValidateISO(...) with unused List<string> parameters—indicating validation results are likely ignored or handled internally by the view model.

4. Dependencies

Imports / External Types Used

System.Collections.Generic, System.Windows, System.Windows.Controls, System.Windows.Media — standard WPF and .NET types.
DTS.Common.Controls — likely contains custom controls (e.g., GridViewColumnHeaderSearchable).
DTS.Common.Enums.Channels — contains ChannelEnumsAndConstants.ChannelCodeType.
DTS.Common.Interface.Channels.ChannelCodes — defines IChannelCodesListView, IChannelCodesListViewModel, IChannelCode.
DTS.Common.Utils — contains Utils.FindChild<T> helper.
ChannelCodes.Resources.StringResources — static resource class for localized strings (e.g., "ISOCode", "UserChannelName").

Inferred Dependencies

Depends on:
- IChannelCodesListViewModel (via DataContext) for filtering, sorting, validation, and selection state.
- IChannelCode interface for individual code objects.
- Custom control GridViewColumnHeaderSearchable for searchable column headers.
- ChannelCodesListView.xaml (implicit dependency via InitializeComponent()).
Depended on by:
- Likely consumed by a parent view or shell that binds an IChannelCodesListViewModel instance to its DataContext.

5. Gotchas

Silent failures: Most handlers return early if DataContext is not ChannelCodesListViewModel (or IChannelCodesListViewModel), leading to no-op behavior without logging or exceptions.
Unused validation outputs: All ValidateUser/ValidateISO calls instantiate and pass new List<string>() for out/ref parameters, but the lists are never used—suggesting validation errors are either ignored or handled via side effects (e.g., raising INotifyDataErrorInfo or UI bindings).
Redundant selection handling: Multiple event handlers (ISO_Checked, User_Checked, *SelectionChanged, *TextBox*SelectionChanged) all call vm.SetISOSelection(...) or vm.SetUserSelection(...), potentially causing duplicate or conflicting selection updates. This may indicate legacy or overlapping event wiring.
Hit-test complexity: ISOChannelCodesListView_PreviewMouseLeftButtonUp and UserChannelCodesListView_PreviewMouseLeftButtonUp use multiple hit tests (VisualTreeHelper.HitTest, InputHitTest) and descendant checks to determine sort triggers—fragile and hard to maintain. Sorting is triggered on clicks anywhere in a column header, including TextBlocks with specific localized text.
Commented-out code: A ChannelType_SelectionChanged handler is commented out, suggesting incomplete or deprecated logic.
Assumed control types: Handlers assume specific control types (TextBox, ListView, TextBlock, Control) and cast them directly—could throw if XAML changes unexpectedly.

None identified beyond the above.

5.5 KiB Raw Blame History